wasmtime / issue #5952 Cranelift: Wrong result for `fcvt_... · git-wasmtime · Zulip Chat Archive

Stream: git-wasmtime

Topic: wasmtime / issue #5952 Cranelift: Wrong result for `fcvt_...

Wasmtime GitHub notifications bot (Mar 07 2023 at 16:33):

afonso360 opened issue #5952:

:wave: Hey,

I re-ran the fuzzer today with the issues that were fixed in the past weeks, and it reported some new cases.

.clif Test Case
test interpret
test run
target riscv64gc

function %a(i16 uext) -> f32 {
block0(v0: i16):
    v1 = fcvt_from_sint.f32 v0
    return v1
}

; run: %a(-12800) == -0x1.900000p13
Steps to Reproduce

clif-util test ./the-above.clif

Expected Results

The test to pass!

Actual Results
 ERROR cranelift_filetests::concurrent > FAIL: run
FAIL ./lmao.clif: run

Caused by:
    Failed test: run: %a(-12800) == -0x1.900000p13, actual: 0x1.9c0000p15
1 tests
Error: 1 failure
Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: RISCV64GC

Extra Info

CC: @yuyang-ok

Wasmtime GitHub notifications bot (Mar 07 2023 at 16:33):

afonso360 labeled issue #5952:

:wave: Hey,

I re-ran the fuzzer today with the issues that were fixed in the past weeks, and it reported some new cases.

.clif Test Case
test interpret
test run
target riscv64gc

function %a(i16 uext) -> f32 {
block0(v0: i16):
    v1 = fcvt_from_sint.f32 v0
    return v1
}

; run: %a(-12800) == -0x1.900000p13
Steps to Reproduce

clif-util test ./the-above.clif

Expected Results

The test to pass!

Actual Results
 ERROR cranelift_filetests::concurrent > FAIL: run
FAIL ./lmao.clif: run

Caused by:
    Failed test: run: %a(-12800) == -0x1.900000p13, actual: 0x1.9c0000p15
1 tests
Error: 1 failure
Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: RISCV64GC

Extra Info

CC: @yuyang-ok

Wasmtime GitHub notifications bot (Mar 07 2023 at 16:33):

afonso360 labeled issue #5952:

:wave: Hey,

I re-ran the fuzzer today with the issues that were fixed in the past weeks, and it reported some new cases.

.clif Test Case
test interpret
test run
target riscv64gc

function %a(i16 uext) -> f32 {
block0(v0: i16):
    v1 = fcvt_from_sint.f32 v0
    return v1
}

; run: %a(-12800) == -0x1.900000p13
Steps to Reproduce

clif-util test ./the-above.clif

Expected Results

The test to pass!

Actual Results
 ERROR cranelift_filetests::concurrent > FAIL: run
FAIL ./lmao.clif: run

Caused by:
    Failed test: run: %a(-12800) == -0x1.900000p13, actual: 0x1.9c0000p15
1 tests
Error: 1 failure
Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: RISCV64GC

Extra Info

CC: @yuyang-ok

Wasmtime GitHub notifications bot (Mar 07 2023 at 16:33):

afonso360 labeled issue #5952:

:wave: Hey,

I re-ran the fuzzer today with the issues that were fixed in the past weeks, and it reported some new cases.

.clif Test Case
test interpret
test run
target riscv64gc

function %a(i16 uext) -> f32 {
block0(v0: i16):
    v1 = fcvt_from_sint.f32 v0
    return v1
}

; run: %a(-12800) == -0x1.900000p13
Steps to Reproduce

clif-util test ./the-above.clif

Expected Results

The test to pass!

Actual Results
 ERROR cranelift_filetests::concurrent > FAIL: run
FAIL ./lmao.clif: run

Caused by:
    Failed test: run: %a(-12800) == -0x1.900000p13, actual: 0x1.9c0000p15
1 tests
Error: 1 failure
Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: RISCV64GC

Extra Info

CC: @yuyang-ok

Wasmtime GitHub notifications bot (Mar 07 2023 at 16:34):

afonso360 edited issue #5952:

:wave: Hey,

I re-ran the fuzzer today with the issues that were fixed in the past weeks, and it reported some new cases.

.clif Test Case
test interpret
test run
target riscv64gc

function %a(i16 uext) -> f32 {
block0(v0: i16):
    v1 = fcvt_from_sint.f32 v0
    return v1
}

; run: %a(-12800) == -0x1.900000p13
Steps to Reproduce

clif-util test ./the-above.clif

Expected Results

The test to pass!

Actual Results
 ERROR cranelift_filetests::concurrent > FAIL: run
FAIL ./lmao.clif: run

Caused by:
    Failed test: run: %a(-12800) == -0x1.900000p13, actual: 0x1.9c0000p15
1 tests
Error: 1 failure
Versions and Environment

Cranelift version or commit: main (e2dcb19099606f161c6d6145ba71130579b452e2)

Operating system: Linux

Architecture: RISCV64GC

Extra Info

CC: @yuyang-ok

Wasmtime GitHub notifications bot (Mar 08 2023 at 06:02):

yuyang-ok commented on issue #5952:

@afonso360 :+1:

Wasmtime GitHub notifications bot (Mar 08 2023 at 06:09):

yuyang-ok commented on issue #5952:

@afonso360 Looking at the ISLE lowering rules.I think we should extend value first.

Wasmtime GitHub notifications bot (Mar 08 2023 at 06:17):

yuyang-ok edited a comment on issue #5952:

@afonso360 Looking at the ISLE lowering rules.I think we should extend from value first.

Wasmtime GitHub notifications bot (Mar 08 2023 at 09:00):

yuyang-ok deleted a comment on issue #5952:

@afonso360 :+1:

Wasmtime GitHub notifications bot (Mar 09 2023 at 06:07):

yuyang-ok commented on issue #5952:

@afonso360 Maybe a review. #5964

Wasmtime GitHub notifications bot (Mar 10 2023 at 11:08):

afonso360 closed issue #5952:

:wave: Hey,

I re-ran the fuzzer today with the issues that were fixed in the past weeks, and it reported some new cases.

.clif Test Case
test interpret
test run
target riscv64gc

function %a(i16 uext) -> f32 {
block0(v0: i16):
    v1 = fcvt_from_sint.f32 v0
    return v1
}

; run: %a(-12800) == -0x1.900000p13
Steps to Reproduce

clif-util test ./the-above.clif

Expected Results

The test to pass!

Actual Results
 ERROR cranelift_filetests::concurrent > FAIL: run
FAIL ./lmao.clif: run

Caused by:
    Failed test: run: %a(-12800) == -0x1.900000p13, actual: 0x1.9c0000p15
1 tests
Error: 1 failure
Versions and Environment

Cranelift version or commit: main (e2dcb19099606f161c6d6145ba71130579b452e2)

Operating system: Linux

Architecture: RISCV64GC

Extra Info

CC: @yuyang-ok

Last updated: Nov 22 2024 at 16:03 UTC