Wasmtime GitHub notifications bot (Feb 27 2023 at 15:07): Wasmtime GitHub notifications bot (Feb 27 2023 at 15:07):alexcrichton commented on issue #5880:
True! Wasm-based fuzzing, however, should extensively test the simd proposal with differential execution against v8.
Wasmtime GitHub notifications bot (Feb 27 2023 at 19:44):cfallin commented on issue #5880:
To the fuzzing point, one request (if you haven't already planned it this way): could we hold off merging this until Mar 5, when the next release branch is cut, so we maximize fuzz time at 6 weeks rather than 2? I think it's great we're getting this but given history with SIMD loads I too am a bit apprehensive :-)
Wasmtime GitHub notifications bot (Feb 27 2023 at 20:06):alexcrichton commented on issue #5880:
I don't mind, but I'd also push back a bit in that https://github.com/bytecodealliance/wasmtime/pull/5849, https://github.com/bytecodealliance/wasmtime/pull/5841, and https://github.com/bytecodealliance/wasmtime/pull/5819 were sort of all much larger/riskier. I had good success uncovering semantic issues through fuzzing in not much time as well.
Would you prefer, though, to back out those PRs and re-land after the cutoff?
Wasmtime GitHub notifications bot (Feb 27 2023 at 20:12):cfallin commented on issue #5880:
Ah, yeah, that's a fair point that my request isn't really consistent, and I hadn't connected the dots; given those are already in, I retract my request as I don't think this is any more risk in comparison.
Last updated: Dec 23 2024 at 12:05 UTC