Wasmtime GitHub notifications bot (Feb 24 2023 at 11:24): Wasmtime GitHub notifications bot (Feb 24 2023 at 11:24):yuyang-ok commented on issue #5873:
normalize_cmp_value
Wasmtime GitHub notifications bot (Feb 24 2023 at 11:24):yuyang-ok edited a comment on issue #5873:
The code have been change from origin implementation.
I see a normalize_cmp_value is wrong.
riscv64 can only compare int64 value.
normalize_cmp_value should do a singed extend rather than zero extend on I8 and I16 .
i32 implemented correctly.
Wasmtime GitHub notifications bot (Feb 24 2023 at 12:02):yuyang-ok commented on issue #5873:
Maybe routine
normalize_cmp_valuecan accept the compare it singed or unsigned.
right now singed extend is always right.
Wasmtime GitHub notifications bot (Feb 24 2023 at 12:04):yuyang-ok deleted a comment on issue #5873:
Maybe routine
normalize_cmp_valuecan accept the compare it singed or unsigned.
right now singed extend is always right.
Wasmtime GitHub notifications bot (Feb 24 2023 at 12:07):yuyang-ok deleted a comment on issue #5873:
The code have been change from origin implementation.
I see a normalize_cmp_value is wrong.
riscv64 can only compare int64 value.
normalize_cmp_value should do a singed extend rather than zero extend on I8 and I16 .
i32 implemented correctly.
Wasmtime GitHub notifications bot (Feb 24 2023 at 16:58):pchickey commented on issue #5873:
In the future, could you please mention some words related to the issue in the PR title, rather than just the issue number? I ask this because Wasmtime is a very busy repository and many of us get notifications for all activity, which we then have to filter down manually - for instance, I don't work on Cranelift, so I end up manually muting all Cranelift issues and PRs.
This is a very minor inconvenience and I don't want to be negative on your work. I appreciate your involvement in this project!
Wasmtime GitHub notifications bot (Feb 24 2023 at 23:18):yuyang-ok commented on issue #5873:
@pchickey Yeah sure.
Last updated: Nov 22 2024 at 16:03 UTC