Stream: git-wasmtime

Topic: wasmtime / issue #5873 fix codegen riscv64 normalize_cmp...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 01:37):

jameysharp commented on issue #5873:

@afonso360, you've been working on the sign-extension bits this PR relies on, as well as the select lowerings that this affects. What are your thoughts on this PR?

I was wondering if it would be better to pass an ExtendOp to normalize_cmp_value, instead of an IntCC. Most of the callers always want a zero-extend and some of them have to fake a condition code in this PR, so maybe passing the choice of sign-extending or zero-extending directly would be more clear.

I don't know what the best way to do this is. I think I understand this PR though, and if it looks good to @afonso360 then it looks good to me.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 02:26):

yuyang-ok commented on issue #5873:

@jameysharp It is hard to decide use IntCC or ExtendOp as parameter to normalize_cmp_value too.
Because the function named normalize_cmp_value I thought maybe better pass the IntCC.
Actualy IntCC.Equal and IntCC.NotEqual make no differrence.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 02:28):

yuyang-ok edited a comment on issue #5873:

@jameysharp It is hard to decide use IntCC or ExtendOp as parameter to normalize_cmp_value to me too.
Because the function named normalize_cmp_value I thought maybe better pass the IntCC.
Actualy IntCC.Equal and IntCC.NotEqual make no differrence.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 02:37):

yuyang-ok commented on issue #5873:

@jameysharp Maybe a convert So we can accept IntCC and ExtendOP both.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 02:39):

yuyang-ok edited a comment on issue #5873:

@jameysharp Maybe a convert So we can accept IntCC and ExtendOP both.
Like convert Intcc ExtendOp convert_intcc_to_extend_op and normalize_cmp_value accept ExtendOp as parameter.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 02:43):

yuyang-ok edited a comment on issue #5873:

@jameysharp Maybe a convert So we can accept IntCC and ExtendOP both.
Like (convert Intcc ExtendOp convert_intcc_to_extend_op) and normalize_cmp_value accept ExtendOp as parameter.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 07:18):

yuyang-ok commented on issue #5873:

@jameysharp I have changed the parameter to ExtendOp.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 22:29):

yuyang-ok commented on issue #5873:

@jameysharp @afonso360 I think we are ready.

Last updated: Oct 23 2024 at 20:03 UTC