Stream: git-wasmtime

Topic: wasmtime / issue #5859 Cranelift: Panic with `smax.i16+lo...

Wasmtime GitHub notifications bot (Feb 23 2023 at 10:53):

afonso360 edited issue #5859:

:wave: Hey,

cranelift-icache found this issue.

.clif Test Case

test compile
target s390x

function u1:0() -> i16 uext system_v {
    ss0 = explicit_slot 85

block0:
    v36 = iconst.i16 0x5551
    v149 = stack_load.i16 ss0+42
    v151 = smax v149, v36
    return v151
}

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The test to pass

Actual Results

     Running `/home/afonso/git/wasmtime/target/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'assertion failed: !self.inst_sunk.contains(&inst)', cranelift/codegen/src/machinst/lower.rs:1290:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: assertion failed: !self.inst_sunk.contains(&inst)
FAIL ./lmao.clif: panicked in worker #0: assertion failed: !self.inst_sunk.contains(&inst)
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: s390x

Extra Info

This only happens on i16 and i8's. Passes with i32/i64.

cc: @uweigand

Wasmtime GitHub notifications bot (Feb 23 2023 at 15:24):

uweigand commented on issue #5859:

Thanks for the report! I've posted a fix now.

Wasmtime GitHub notifications bot (Feb 23 2023 at 20:36):

jameysharp closed issue #5859:

:wave: Hey,

cranelift-icache found this issue.

.clif Test Case

test compile
target s390x

function u1:0() -> i16 uext system_v {
    ss0 = explicit_slot 85

block0:
    v36 = iconst.i16 0x5551
    v149 = stack_load.i16 ss0+42
    v151 = smax v149, v36
    return v151
}

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The test to pass

Actual Results

     Running `/home/afonso/git/wasmtime/target/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'assertion failed: !self.inst_sunk.contains(&inst)', cranelift/codegen/src/machinst/lower.rs:1290:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: assertion failed: !self.inst_sunk.contains(&inst)
FAIL ./lmao.clif: panicked in worker #0: assertion failed: !self.inst_sunk.contains(&inst)
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: s390x

Extra Info

This only happens on i16 and i8's. Passes with i32/i64.

cc: @uweigand

Last updated: Dec 23 2024 at 12:05 UTC