Wasmtime GitHub notifications bot (Feb 21 2023 at 14:45): Wasmtime GitHub notifications bot (Feb 21 2023 at 14:45):github-actions[bot] commented on issue #5846:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 21 2023 at 21:15):jameysharp commented on issue #5846:
All
vfnmadd*opcodes were added as well. These are pattern-matched where one of the arguments to the CLIF instruction is anfneg. I opted to not add a new CLIF instruction here since it seemed like pattern matching was easy enough but I'm also not intimately familiar with the semantics here so if that's the preferred approach I can do that too.I'd generally prefer not to add CLIF instructions if it seems like we can get just as good of results without them. It sounds like that's the case here, so I think you made the right choice.
Last updated: Nov 22 2024 at 17:03 UTC