Stream: git-wasmtime

Topic: wasmtime / issue #5838 documentation refers to nonexisten...

Wasmtime GitHub notifications bot (Feb 20 2023 at 05:15):

wtholliday opened issue #5838:

From:

https://docs.rs/cranelift-codegen/latest/cranelift_codegen/ir/entities/struct.StackSlot.html

"StackSlots can be created with FunctionBuilder::create_stackslot."

There isn't such a function AFAICT. Perhaps it should be create_sized_stack_slot? I'm new to cranelift.

Wasmtime GitHub notifications bot (Feb 20 2023 at 10:55):

bjorn3 commented on issue #5838:

Indeed. create_stackslot was renamed to create_sized_stack_slot a while ago. Seems this reference was missed. Would you mind opening a PR to update it?

Wasmtime GitHub notifications bot (Mar 02 2023 at 02:35):

jameysharp labeled issue #5838:

From:

https://docs.rs/cranelift-codegen/latest/cranelift_codegen/ir/entities/struct.StackSlot.html

"StackSlots can be created with FunctionBuilder::create_stackslot."

There isn't such a function AFAICT. Perhaps it should be create_sized_stack_slot? I'm new to cranelift.

Wasmtime GitHub notifications bot (Mar 02 2023 at 02:35):

jameysharp labeled issue #5838:

From:

https://docs.rs/cranelift-codegen/latest/cranelift_codegen/ir/entities/struct.StackSlot.html

"StackSlots can be created with FunctionBuilder::create_stackslot."

There isn't such a function AFAICT. Perhaps it should be create_sized_stack_slot? I'm new to cranelift.

Wasmtime GitHub notifications bot (Mar 02 2023 at 02:35):

jameysharp labeled issue #5838:

From:

https://docs.rs/cranelift-codegen/latest/cranelift_codegen/ir/entities/struct.StackSlot.html

"StackSlots can be created with FunctionBuilder::create_stackslot."

There isn't such a function AFAICT. Perhaps it should be create_sized_stack_slot? I'm new to cranelift.

Wasmtime GitHub notifications bot (Apr 09 2023 at 22:35):

cfallin closed issue #5838:

From:

https://docs.rs/cranelift-codegen/latest/cranelift_codegen/ir/entities/struct.StackSlot.html

"StackSlots can be created with FunctionBuilder::create_stackslot."

There isn't such a function AFAICT. Perhaps it should be create_sized_stack_slot? I'm new to cranelift.

Last updated: Nov 22 2024 at 16:03 UTC