Stream: git-wasmtime

Topic: wasmtime / issue #5826 Add Engine::precompile_compatibili...

Wasmtime GitHub notifications bot (Feb 17 2023 at 22:51):

github-actions[bot] commented on issue #5826:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 31 2023 at 18:17):

lann commented on issue #5826:

Finally getting back around to this, I realized that the cache system already generates a key like this, and sure enough this has exactly what I was looking for: https://github.com/bytecodealliance/wasmtime/blob/83d00fea4a881ab1160bf0a609ac463643bc0821/crates/wasmtime/src/module.rs#L1141-L1151

Reusing this code as-is would require changing the function signature a bit, e.g.:

pub fn precompile_compatibility_hash(&self) -> impl std::hash::Hash {
    crate::module::HashedEngineCompileEnv(self)
}

Wasmtime GitHub notifications bot (Apr 05 2023 at 15:01):

alexcrichton commented on issue #5826:

Sounds reasonable to me!

Last updated: Nov 22 2024 at 17:03 UTC