Wasmtime GitHub notifications bot (Feb 13 2023 at 15:43): Wasmtime GitHub notifications bot (Feb 13 2023 at 15:43):alexcrichton commented on issue #5766:
I'll note that if this still seems like something we want to go with despite the possible downsides I'll do a pass over the
docs/contributing-ci.mdfile and write down our new CI steps and such.Additionally merging this PR will logistically require a few changes:
- I'll need to update the branch protections for
main- All PRs to be merged after this one will need to be rebased on top of this one
- I'd enable release-branch protections after the 6.0.0 release is made on the 20th since it won't have these changes.
Wasmtime GitHub notifications bot (Feb 13 2023 at 19:21):alexcrichton commented on issue #5766:
I was hoping to showcase "look this PR ran so little CI" but I forgot that my commit had the string
prtest:fullin it so it ended up running full CI. So I suppose this is an example of a full CI run instead of a minimal one, but you can also see how this is switching up the jobs so the branch protections need modifications
Last updated: Nov 22 2024 at 16:03 UTC