Stream: git-wasmtime

Topic: wasmtime / issue #5755 Inline jump tables in parsed br_ta...

Wasmtime GitHub notifications bot (Feb 09 2023 at 20:33):

bjorn3 commented on issue #5755:

I was actually thinking about suggesting the same thing! Maybe you could even pass the JumpTableData into the br_table builder call directly rather than first requiring to import the jump table into the dfg and then passing the index?

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:27):

jameysharp commented on issue #5755:

Maybe you could even pass the JumpTableData into the br_table builder call directly rather than first requiring to import the jump table into the dfg and then passing the index?

That would be fantastic. I imagine it's a little tedious to implement right now though since it requires special handling in the meta crate's code-generator.

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:30):

elliottt commented on issue #5755:

Maybe you could even pass the JumpTableData into the br_table builder call directly rather than first requiring to import the jump table into the dfg and then passing the index?

That would be fantastic. I imagine it's a little tedious to implement right now though since it requires special handling in the meta crate's code-generator.

I agree this would be really nice to have. How about we tackle it in a follow-up PR, given the complexity that @jameysharp mentioned :)

Wasmtime GitHub notifications bot (Feb 09 2023 at 21:32):

bjorn3 commented on issue #5755:

:100:

Last updated: Dec 23 2024 at 12:05 UTC