Stream: git-wasmtime

Topic: wasmtime / issue #5727 Cranelift DFG: make inst clone dee...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 22:46):

cfallin commented on issue #5727:

(Rebased to unstack from #5726; there's no need to couple these actually)

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 22:54):

jameysharp commented on issue #5727:

Can we generate an InstructionData::deep_clone method in the meta crate by looking at which formats have value-list operands? I'm worried this won't get updated as new formats are added.

The same issue applies to BlockCall, right?

Aside from bugs like #5726 the egraphs code currently can never hit any of these cases, right? I think all the instructions that use value-lists (just block terminators and calls I think) are impure and so are not currently duplicated.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2023 at 22:57):

cfallin commented on issue #5727:

Can we generate an InstructionData::deep_clone method in the meta crate by looking at which formats have value-list operands? I'm worried this won't get updated as new formats are added.

Yep, that's the better approach; I'll build that out.

The same issue applies to BlockCall, right?

Ah, yes, indeed, I'll need to fix that too!

Aside from bugs like #5726 the egraphs code currently can never hit any of these cases, right? I think all the instructions that use value-lists (just block terminators and calls I think) are impure and so are not currently duplicated.

Yep, there's no functional impact today; all pure insts happen to have fixed args.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 00:40):

cfallin commented on issue #5727:

Updated, thanks!


Last updated: Dec 23 2024 at 13:07 UTC