Stream: git-wasmtime

Topic: wasmtime / issue #5723 Cranelift: Only build iconst for i...

Wasmtime GitHub notifications bot (Feb 06 2023 at 21:07):

jameysharp commented on issue #5723:

I think this should be back-ported for the upcoming release, once we've validated this change, even though we haven't received any bug reports about these rules. I don't think it needs to be backported further since this will be the first release with e-graph optimization on by default.

Wasmtime GitHub notifications bot (Feb 06 2023 at 22:11):

jameysharp commented on issue #5723:

If we're generalizing iconst, I'd be tempted to try for a generic const that works with floats and vectors too.

Wasmtime GitHub notifications bot (Feb 06 2023 at 22:29):

cfallin commented on issue #5723:

Perhaps, yeah. I just went to remind myself how fconst works and it turns out that we actually split to fconst32 and fconst64 opcodes, so the situation is even less polymorphic than I had thought. Cleanup would be nice!

Last updated: Nov 22 2024 at 17:03 UTC