Wasmtime GitHub notifications bot (Feb 03 2023 at 22:02): Wasmtime GitHub notifications bot (Feb 03 2023 at 22:02):pchickey commented on issue #5702:
Agree we should update this dep, but I need to learn how to use
cargo vetto generate the correct sort of record for the diff. I'll do my best to take care of that before eod. Our project policy is that only core contributors are trusted to vet packages, but I have never actually done it myself since that policy was set a few months ago.
Wasmtime GitHub notifications bot (Feb 04 2023 at 00:49):pchickey commented on issue #5702:
Please rebase on main after #5707 merges, and remove the last commit modifying the vet toml. Thanks!
Wasmtime GitHub notifications bot (Feb 05 2023 at 00:25):brendandburns commented on issue #5702:
@pchickey rebased, thanks for taking care of the vet part.
Wasmtime GitHub notifications bot (Feb 05 2023 at 00:31):brendandburns commented on issue #5702:
So, I dropped my cargo vet related commit, perhaps I wasn't supposed to do that? Anyway, I'm still seeing this cargo vet error:
Run cargo vet --locked Vetting Failed! 1 unvetted dependencies: base64:0.21.0 missing ["safe-to-deploy"] Error: Process completed with exit code 255.Let me know the right way to fix this.
Thanks!
Wasmtime GitHub notifications bot (Feb 05 2023 at 01:56):pchickey commented on issue #5702:
Nope, thats me making a mistake on the vetting. I'll fix it
Wasmtime GitHub notifications bot (Feb 05 2023 at 01:59):pchickey commented on issue #5702:
https://github.com/bytecodealliance/wasmtime/pull/5710 will fix the vet problem, someone will review it monday. Sorry!
Wasmtime GitHub notifications bot (Feb 06 2023 at 18:28):pchickey commented on issue #5702:
I checked a rebase on main locally and this should be fixed now
Wasmtime GitHub notifications bot (Feb 07 2023 at 04:57):brendandburns commented on issue #5702:
Thanks @pchickey for the fixes and @peterhuene for the quick merge!
Last updated: Dec 23 2024 at 12:05 UTC