Stream: git-wasmtime

Topic: wasmtime / issue #5667 Is there an alternative to InstBui...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 08:28):

ptitSeb opened issue #5667:

InstBuilder::fallthrough_return(...) as been removed. What could be the alternative to it in current Codegen?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 09:51):

bjorn3 commented on issue #5667:

There isn't. It existed only for the purpose of an integration with Spidermonkey (Baldrdash), which required Spidermonkey to create the function prologue and epilogue. fallthrough_return only worked with the Baldrdash calling convention. Baldrdash has since been removed from Spidermonkey and in response the Cranelift side of the integration has been removed too in https://github.com/bytecodealliance/wasmtime/pull/4571.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 09:52):

bjorn3 edited a comment on issue #5667:

There isn't any alternative right now. It existed only for the purpose of an integration with Spidermonkey (Baldrdash), which required Spidermonkey to create the function prologue and epilogue. fallthrough_return only worked with the Baldrdash calling convention. Baldrdash has since been removed from Spidermonkey and in response the Cranelift side of the integration has been removed too in https://github.com/bytecodealliance/wasmtime/pull/4571.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 09:53):

bjorn3 edited a comment on issue #5667:

There isn't any alternative right now. It existed only for the purpose of an integration with Spidermonkey (Baldrdash), which required Spidermonkey to create the function prologue and epilogue. fallthrough_return only worked with the Baldrdash calling convention AFAIK. Baldrdash has since been removed from Spidermonkey and in response the Cranelift side of the integration has been removed too in https://github.com/bytecodealliance/wasmtime/pull/4571.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 09:54):

bjorn3 commented on issue #5667:

Could you tell a bit about the use case you have? Maybe there is an alternative? Or if not this could help with coming up with a design that isn't Spidermonkey specific.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 10:09):

ptitSeb commented on issue #5667:

I don't think we are actually using this. But ReturnMode::FallthroughReturn still exist, so it was in a match arm.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 10:33):

bjorn3 commented on issue #5667:

I can't find it anywhere in the Cranelift source.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 12:11):

ptitSeb commented on issue #5667:

Oh, yeah, you are right, sorry. I mixed up different code origina. I'll close the issue.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 12:11):

ptitSeb closed issue #5667:

InstBuilder::fallthrough_return(...) as been removed. What could be the alternative to it in current Codegen?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 12:11):

ptitSeb edited a comment on issue #5667:

Oh, yeah, you are right, sorry. I mixed up different code origins. I'll close the issue.

Last updated: Oct 23 2024 at 20:03 UTC