Stream: git-wasmtime

Topic: wasmtime / issue #5655 Enable `all-arch` by default.

Wasmtime GitHub notifications bot (Jan 30 2023 at 19:47):

martindevans opened issue #5655:

Feature

Enable the all-arch feature for wasmtime executable.

Benefit

I'm using the compile command to automatically precompile wasm assets for a range of platforms. At the moment this requires me to recompile wasmtime.exe every time there's a new release just to add this feature. Adding this to the executable doesn't seem to have any major drawbacks.

Wasmtime GitHub notifications bot (Jan 30 2023 at 19:51):

cfallin commented on issue #5655:

The main reasons to include only the host architecture's compiler backend by default are (wasmtime) build time and binary size.

It might be useful to have some data here to determine whether this is a good idea:

• Could you measure the size of the binary (on any platform) with just the default features, and all-arch enabled?
• Could you measure the build-time difference, from a clean state, of wasmtime with/without, and also the cranelift-codegen crate alone?

Wasmtime GitHub notifications bot (Jan 30 2023 at 19:56):

alexcrichton commented on issue #5655:

To clarify, though, do you mean by default as in "modify Cargo.toml" or do you mean only for the release assets produced here for example? I'd agree with Chris for the former but for the latter we could pretty easily make that change to the CI production of the binaries.

Wasmtime GitHub notifications bot (Jan 30 2023 at 21:11):

martindevans commented on issue #5655:

I don't know Rust particularly well so I'm not too sure about modifying cargo.toml, but I don't think that's what I mean. I'm definitely talking only about enabling it for the release assets you linked.

Wasmtime GitHub notifications bot (Jan 30 2023 at 21:22):

cfallin commented on issue #5655:

Seems like a reasonable change; I just created #5657 for this.

Wasmtime GitHub notifications bot (Jan 30 2023 at 21:22):

martindevans commented on issue #5655:

Wow, thanks for the fast turnaround!

Wasmtime GitHub notifications bot (Jan 30 2023 at 22:58):

cfallin closed issue #5655:

Feature

Enable the all-arch feature for wasmtime executable.

Benefit

I'm using the compile command to automatically precompile wasm assets for a range of platforms. At the moment this requires me to recompile wasmtime.exe every time there's a new release just to add this feature. Adding this to the executable doesn't seem to have any major drawbacks.

Last updated: Nov 22 2024 at 17:03 UTC