Stream: git-wasmtime

Topic: wasmtime / issue #5611 fix rotl.i16 with i128 shift value.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2023 at 10:32):

yuyang-ok edited a comment on issue #5611:

@hch12907 Ok,I Think works the same.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 29 2023 at 07:11):

yuyang-ok commented on issue #5611:

@afonso360 are you going to review this??

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2023 at 23:44):

cfallin commented on issue #5611:

Looks like a test failure in an expected-output test. Once that is fixed, I'm happy to merge!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 04:54):

yuyang-ok commented on issue #5611:

@cfallin Yes,I am trying to fix this.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 04:55):

yuyang-ok edited a comment on issue #5611:

@cfallin Yes,I am trying to fix CI failure.
.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 04:55):

yuyang-ok edited a comment on issue #5611:

@cfallin Yes,I am trying to fix CI failure.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 23:30):

yuyang-ok commented on issue #5611:

<img width="1568" alt="image" src="https://user-images.githubusercontent.com/96557710/215907350-e1c7167c-e182-40d5-bd0a-33129bd17281.png">
This failure related to x86_64 backend???

view this post on Zulip Wasmtime GitHub notifications bot (Jan 31 2023 at 23:39):

cfallin commented on issue #5611:

Ah, yes, i128 in runtests on x86-64 requires set enable_llvm_abi_extensions=true before the target lines. You can see examples in other runtests (e.g., i128-call.clif). I think once you add that, it should pass.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 00:04):

yuyang-ok commented on issue #5611:

@cfallin Thanks.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 00:59):

cfallin commented on issue #5611:

I filed #5680 for the failing test here, as that's an issue on main too. Once we have a fix for that, we can rebase and then merge this I think.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 01:56):

yuyang-ok commented on issue #5611:

@cfallin ok.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 02:56):

cfallin commented on issue #5611:

I just pushed a merge commit onto this branch with the latest main including fixes; should pass now, will merge if so.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 03:23):

yuyang-ok commented on issue #5611:

@cfallin cool.

Last updated: Oct 23 2024 at 20:03 UTC