yuyang-ok edited a comment on issue #5611:
@hch12907 Ok,I Think works the same.
yuyang-ok commented on issue #5611:
@afonso360 are you going to review this??
cfallin commented on issue #5611:
Looks like a test failure in an expected-output test. Once that is fixed, I'm happy to merge!
yuyang-ok commented on issue #5611:
@cfallin Yes,I am trying to fix this.
yuyang-ok edited a comment on issue #5611:
@cfallin Yes,I am trying to fix
CI
failure.
.
yuyang-ok edited a comment on issue #5611:
@cfallin Yes,I am trying to fix
CI
failure.
yuyang-ok commented on issue #5611:
<img width="1568" alt="image" src="https://user-images.githubusercontent.com/96557710/215907350-e1c7167c-e182-40d5-bd0a-33129bd17281.png">
This failure related to x86_64 backend???
cfallin commented on issue #5611:
Ah, yes,
i128
in runtests on x86-64 requiresset enable_llvm_abi_extensions=true
before thetarget
lines. You can see examples in other runtests (e.g.,i128-call.clif
). I think once you add that, it should pass.
yuyang-ok commented on issue #5611:
@cfallin Thanks.
cfallin commented on issue #5611:
I filed #5680 for the failing test here, as that's an issue on
main
too. Once we have a fix for that, we can rebase and then merge this I think.
yuyang-ok commented on issue #5611:
@cfallin ok.
cfallin commented on issue #5611:
I just pushed a merge commit onto this branch with the latest
main
including fixes; should pass now, will merge if so.
yuyang-ok commented on issue #5611:
@cfallin cool.
Last updated: Dec 23 2024 at 13:07 UTC