Wasmtime GitHub notifications bot (Jan 18 2023 at 16:49): Wasmtime GitHub notifications bot (Jan 18 2023 at 16:49):KevinRizzoTO commented on issue #5588:
I'm wondering if we should tweak a bit the directory structure of the test files? I'm thinking that we'd want to have multiple files per supported architecture: e.g.
filetests/x64/simple.watandfiletests/aarch64/simple.wat, if we don't do this we'd probably end up with files named assimple_x64.watMaybe a glob-type pattern would make more sense here! So look for all
.watfiles in a nested directory structure and then append each one to the name of the test case.
Wasmtime GitHub notifications bot (Jan 18 2023 at 16:49):KevinRizzoTO commented on issue #5588:
I'm wondering if we should tweak a bit the directory structure of the test files? I'm thinking that we'd want to have multiple files per supported architecture: e.g.
filetests/x64/simple.watandfiletests/aarch64/simple.wat, if we don't do this we'd probably end up with files named assimple_x64.watMaybe a glob-type pattern would make more sense here! So look for all
.watfiles in a nested directory structure and then append each one to the name of the test case.
Wasmtime GitHub notifications bot (Jan 18 2023 at 16:50):KevinRizzoTO deleted a comment on issue #5588:
I'm wondering if we should tweak a bit the directory structure of the test files? I'm thinking that we'd want to have multiple files per supported architecture: e.g.
filetests/x64/simple.watandfiletests/aarch64/simple.wat, if we don't do this we'd probably end up with files named assimple_x64.watMaybe a glob-type pattern would make more sense here! So look for all
.watfiles in a nested directory structure and then append each one to the name of the test case.
Wasmtime GitHub notifications bot (Jan 18 2023 at 17:20):saulecabrera commented on issue #5588:
Maybe a glob-type pattern would make more sense here! So look for all .wat files in a nested directory structure and then append each one to the name of the test case.
Agreed. Poor wording on my end, but I meant how we _handle_ the directory structure of the filetests; the outcome that I expect is what you described.
Wasmtime GitHub notifications bot (Jan 18 2023 at 18:34):github-actions[bot] commented on issue #5588:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "cranelift", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Last updated: Nov 22 2024 at 17:03 UTC