Stream: git-wasmtime

Topic: wasmtime / issue #5558 Add component model wasmtime featu...

Wasmtime GitHub notifications bot (Jan 11 2023 at 16:38):

github-actions[bot] commented on issue #5558:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jan 11 2023 at 16:52):

jameysharp commented on issue #5558:

Do we need to add anything to CI to check that docs build successfully when the "component-model" feature is active? It'd be sad to do a release that docs.rs fails to build.

Wasmtime GitHub notifications bot (Jan 11 2023 at 16:58):

Kylebrown9 commented on issue #5558:

That seems like a reasonable thing to automate, want to file that as an issue to improve the CI?

Wasmtime GitHub notifications bot (Jan 11 2023 at 18:08):

jameysharp commented on issue #5558:

We already have a CI job running cargo doc. What I'm not sure of is whether we need to change it for this. I think we probably do...?

Wasmtime GitHub notifications bot (Jan 11 2023 at 18:27):

Kylebrown9 commented on issue #5558:

I would hope that it would respect the Cargo.toml contents for each crate.

Wasmtime GitHub notifications bot (Jan 11 2023 at 18:29):

jameysharp commented on issue #5558:

It does, but I don't think cargo doc reads the [package.metadata.docs.rs] section. I think that's specifically for the docs.rs invocation of cargo doc.

Last updated: Dec 23 2024 at 12:05 UTC