abrown commented on issue #5548:
...it's also a bit worrying that the CI didn't pick that up?!
jameysharp commented on issue #5548:
I was worried about CI for a moment after seeing your comment too. But both remaining uses of
PredicateNode::Not
are in a macro, in branches which were only used by the now-deletedpredicate!(!is_pic)
. Since that macro is never expanded with input matching those cases, the compiler didn't see anything wrong.We should delete both
!$a:ident
cases frommacro_rules! predicate
now, but fortunately the only harm in leaving them there is confusion during maintenance later.
abrown commented on issue #5548:
Ah, good!
afonso360 commented on issue #5548:
Good catch! I've opened #5552 to address this
Last updated: Dec 23 2024 at 12:05 UTC