Stream: git-wasmtime

Topic: wasmtime / issue #5548 cranelift: Remove `is_pic` predica...

Wasmtime GitHub notifications bot (Jan 09 2023 at 18:07):

abrown commented on issue #5548:

...it's also a bit worrying that the CI didn't pick that up?!

Wasmtime GitHub notifications bot (Jan 09 2023 at 18:18):

jameysharp commented on issue #5548:

I was worried about CI for a moment after seeing your comment too. But both remaining uses of PredicateNode::Not are in a macro, in branches which were only used by the now-deleted predicate!(!is_pic). Since that macro is never expanded with input matching those cases, the compiler didn't see anything wrong.

We should delete both !$a:ident cases from macro_rules! predicate now, but fortunately the only harm in leaving them there is confusion during maintenance later.

Wasmtime GitHub notifications bot (Jan 09 2023 at 18:19):

abrown commented on issue #5548:

Ah, good!

Wasmtime GitHub notifications bot (Jan 09 2023 at 18:51):

afonso360 commented on issue #5548:

Good catch! I've opened #5552 to address this

Last updated: Nov 22 2024 at 17:03 UTC