Stream: git-wasmtime

Topic: wasmtime / issue #5534 Cranelift: GVN all idempotently tr...

Wasmtime GitHub notifications bot (Jan 05 2023 at 23:08):

fitzgen commented on issue #5534:

Makes sense to me! I missed the introduction of side_effects_idempotent so I'm not sure if the egraph case handles it too or if it's only simple-gvn. But I think this should be safe to merge either way.

It is just simple_gvn for now, but shouldn't be hard to introduce to the egraphs stuff since it's just a predicate on the opcode, and not some deep logic that needs to be copied over. I didn't implement it just because I don't know exactly where that would go yet. Maybe you do?

Wasmtime GitHub notifications bot (Jan 06 2023 at 02:03):

jameysharp commented on issue #5534:

I think the place to use side_effects_idempotent for egraph optimization is in is_pure_for_egraph, defined in cranelift/codegen/src/inst_predicates.rs. I'm not absolutely sure though.

Last updated: Oct 23 2024 at 20:03 UTC