Stream: git-wasmtime

Topic: wasmtime / issue #5484 wasi-threads: an initial implement...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 21 2022 at 00:21):

github-actions[bot] commented on issue #5484:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 17:39):

alexcrichton commented on issue #5484:

Oh one thing as well, it looks like this test may not be running on CI since it requires explicit opt-in to run. That being said including the threads feature in the build by default I think is reasonable since it doesn't pull in any extra build requirements and still requires a flag to enable at runtime.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 17:46):

abrown commented on issue #5484:

Oh one thing as well, it looks like this test may not be running on CI since it requires explicit opt-in to run. That being said including the threads feature in the build by default I think is reasonable since it doesn't pull in any extra build requirements and still requires a flag to enable at runtime.

That sounds good, but out of an abundance of caution, can we merge as-is, then make the feature default? I want to get a few days of no-issue CI builds and general usage. Also, I want to take another pass on the testing side, improving the one existing test and possibly including some other tests that others have been working on.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 17:47):

alexcrichton commented on issue #5484:

Sure yeah, would you prefer to not test at all on CI while manual testing is done?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 18:23):

abrown commented on issue #5484:

I'm fine with manual testing for now (like, a week?) of the wasi-threads parts; the parts I'm concerned about getting some usage of are the changes to wasi-common.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2023 at 18:24):

abrown edited a comment on issue #5484:

I'm fine with manual testing for now (like, a week?) of the wasi-threads parts--they are pretty straight-forward. The parts I'm concerned about getting some usage of are the changes to wasi-common.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2023 at 20:11):

abrown commented on issue #5484:

Rebased to handle conflicts due to version bumps and #5683.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2023 at 14:01):

TerrorJack commented on issue #5484:

Note that the thread-spawn name in wasi-libc isn't coherent with the thread_spawn name used in wasmtime.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2023 at 17:35):

abrown commented on issue #5484:

Note that the thread-spawn name in wasi-libc isn't coherent with the thread_spawn name used in wasmtime.

@TerrorJack, thanks for the heads up. Yes, there are a few details that still need to be cleaned up, like this one. I opened #5748 to resolve this.

Last updated: Nov 22 2024 at 17:03 UTC