github-actions[bot] commented on issue #5484:
Subscribe to Label Action
cc @kubkon
<details>
This issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
- kubkon: wasi
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton commented on issue #5484:
Oh one thing as well, it looks like this test may not be running on CI since it requires explicit opt-in to run. That being said including the threads feature in the build by default I think is reasonable since it doesn't pull in any extra build requirements and still requires a flag to enable at runtime.
abrown commented on issue #5484:
Oh one thing as well, it looks like this test may not be running on CI since it requires explicit opt-in to run. That being said including the threads feature in the build by default I think is reasonable since it doesn't pull in any extra build requirements and still requires a flag to enable at runtime.
That sounds good, but out of an abundance of caution, can we merge as-is, then make the feature default? I want to get a few days of no-issue CI builds and general usage. Also, I want to take another pass on the testing side, improving the one existing test and possibly including some other tests that others have been working on.
alexcrichton commented on issue #5484:
Sure yeah, would you prefer to not test at all on CI while manual testing is done?
abrown commented on issue #5484:
I'm fine with manual testing for now (like, a week?) of the wasi-threads parts; the parts I'm concerned about getting some usage of are the changes to wasi-common.
abrown edited a comment on issue #5484:
I'm fine with manual testing for now (like, a week?) of the wasi-threads parts--they are pretty straight-forward. The parts I'm concerned about getting some usage of are the changes to wasi-common.
abrown commented on issue #5484:
Rebased to handle conflicts due to version bumps and #5683.
TerrorJack commented on issue #5484:
Note that the
thread-spawn
name inwasi-libc
isn't coherent with thethread_spawn
name used inwasmtime
.
abrown commented on issue #5484:
Note that the
thread-spawn
name inwasi-libc
isn't coherent with thethread_spawn
name used inwasmtime
.@TerrorJack, thanks for the heads up. Yes, there are a few details that still need to be cleaned up, like this one. I opened #5748 to resolve this.
Last updated: Dec 23 2024 at 12:05 UTC