Stream: git-wasmtime

Topic: wasmtime / issue #5469 fuzzgen: Add `iabs`/`umulhi`/`smulhi`


view this post on Zulip Wasmtime GitHub notifications bot (Dec 19 2022 at 20:40):

jameysharp commented on issue #5469:

@cfallin, @elliottt, and I discussed today whether smulhi and umulhi should support I128. I'm not sure if we came to a solid conclusion.

On one hand, they're kind of a pain to implement and we're not sure how useful they are. I guess these would be useful for bignums, but only if you're using 128-bit limbs, which is maybe a poor life choice on 64-bit targets.

On the other hand, that's not a very strong argument for leaving a hole in the supported types, inconsistent with other instructions. We'd generally prefer to support all types on all operations where it's clear what the operation should do with that type.

Personally, my preference would be that we should go ahead and implement I128 for consistency. But I also doubt that anyone is going to prioritize doing that work any time soon.


Last updated: Dec 23 2024 at 12:05 UTC