Stream: git-wasmtime

Topic: wasmtime / issue #5467 Cranelift: `iabs.i128` not impleme...

Wasmtime GitHub notifications bot (Dec 18 2022 at 12:28):

afonso360 opened issue #5467:

:wave: Hey

.clif Test Case

test interpret
test run
target aarch64

function %iabs_i128(i128) -> i128 {
block0(v0: i128):
    v1 = iabs.i128 v0
    return v1
}
; run: %iabs_i128(1) == 1
; run: %iabs_i128(-1) == 1

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The above test to pass

Actual Results

    Finished dev [unoptimized + debuginfo] target(s) in 0.17s
     Running `qemu-aarch64 -L /usr/aarch64-linux-gnu -E LD_LIBRARY_PATH=/usr/aarch64-linux-gnu/lib /home/afonso/git/wasmtime/target/aarch64-unknown-linux-gnu/debug/clif-util test ./lmao.clif`
thread 'worker #1' panicked at 'should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`', cranelift/codegen/src/machinst/lower.rs:753:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #1: should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`
FAIL ./lmao.clif: panicked in worker #1: should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main
Operating system: Linux
Architecture: AArch64

Wasmtime GitHub notifications bot (Dec 18 2022 at 12:28):

afonso360 labeled issue #5467:

:wave: Hey

.clif Test Case

test interpret
test run
target aarch64

function %iabs_i128(i128) -> i128 {
block0(v0: i128):
    v1 = iabs.i128 v0
    return v1
}
; run: %iabs_i128(1) == 1
; run: %iabs_i128(-1) == 1

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The above test to pass

Actual Results

    Finished dev [unoptimized + debuginfo] target(s) in 0.17s
     Running `qemu-aarch64 -L /usr/aarch64-linux-gnu -E LD_LIBRARY_PATH=/usr/aarch64-linux-gnu/lib /home/afonso/git/wasmtime/target/aarch64-unknown-linux-gnu/debug/clif-util test ./lmao.clif`
thread 'worker #1' panicked at 'should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`', cranelift/codegen/src/machinst/lower.rs:753:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #1: should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`
FAIL ./lmao.clif: panicked in worker #1: should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main
Operating system: Linux
Architecture: AArch64

Wasmtime GitHub notifications bot (Dec 18 2022 at 12:28):

afonso360 labeled issue #5467:

:wave: Hey

.clif Test Case

test interpret
test run
target aarch64

function %iabs_i128(i128) -> i128 {
block0(v0: i128):
    v1 = iabs.i128 v0
    return v1
}
; run: %iabs_i128(1) == 1
; run: %iabs_i128(-1) == 1

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The above test to pass

Actual Results

    Finished dev [unoptimized + debuginfo] target(s) in 0.17s
     Running `qemu-aarch64 -L /usr/aarch64-linux-gnu -E LD_LIBRARY_PATH=/usr/aarch64-linux-gnu/lib /home/afonso/git/wasmtime/target/aarch64-unknown-linux-gnu/debug/clif-util test ./lmao.clif`
thread 'worker #1' panicked at 'should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`', cranelift/codegen/src/machinst/lower.rs:753:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #1: should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`
FAIL ./lmao.clif: panicked in worker #1: should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main
Operating system: Linux
Architecture: AArch64

Wasmtime GitHub notifications bot (Oct 07 2023 at 14:48):

p3achyjr commented on issue #5467:

I can work on this--seems like a reasonable follow-up to https://github.com/bytecodealliance/wasmtime/issues/5466 :)

Wasmtime GitHub notifications bot (Oct 08 2023 at 04:08):

p3achyjr commented on issue #5467:

qq--how do we run aarch64 tests if we only have an x86 machine? I don't see qemu in my directory anywhere, even though it seems like that's how CI is being run.

Wasmtime GitHub notifications bot (Oct 08 2023 at 09:48):

afonso360 commented on issue #5467:

Have a look at the cross-compiling document It describes how we configure QEMU to run as part of cargo test and cargo run. A super useful way of doing things!

If you'd like to run the full testsuite we have a separate script that you can use:

./ci/run-tests.sh --target aarch64-unknown-linux-gnu --locked

Wasmtime GitHub notifications bot (Oct 08 2023 at 15:55):

p3achyjr commented on issue #5467:

Thanks for getting back! Super helpful. Everything passes :)

Wasmtime GitHub notifications bot (Oct 08 2023 at 16:01):

p3achyjr edited a comment on issue #5467:

Thanks for getting back! Really appreciate it. Everything passes :)

Wasmtime GitHub notifications bot (Oct 10 2023 at 09:23):

afonso360 commented on issue #5467:

This has been implemented in #7185. Thanks!

Wasmtime GitHub notifications bot (Oct 10 2023 at 09:23):

afonso360 closed issue #5467:

:wave: Hey

.clif Test Case

test interpret
test run
target aarch64

function %iabs_i128(i128) -> i128 {
block0(v0: i128):
    v1 = iabs.i128 v0
    return v1
}
; run: %iabs_i128(1) == 1
; run: %iabs_i128(-1) == 1

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The above test to pass

Actual Results

    Finished dev [unoptimized + debuginfo] target(s) in 0.17s
     Running `qemu-aarch64 -L /usr/aarch64-linux-gnu -E LD_LIBRARY_PATH=/usr/aarch64-linux-gnu/lib /home/afonso/git/wasmtime/target/aarch64-unknown-linux-gnu/debug/clif-util test ./lmao.clif`
thread 'worker #1' panicked at 'should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`', cranelift/codegen/src/machinst/lower.rs:753:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #1: should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`
FAIL ./lmao.clif: panicked in worker #1: should be implemented in ISLE: inst = `v1 = iabs.i128 v0`, type = `Some(types::I128)`
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main
Operating system: Linux
Architecture: AArch64

Last updated: Nov 22 2024 at 17:03 UTC