Stream: git-wasmtime

Topic: wasmtime / issue #5452 Cranelift: `select_spectre_guard` ...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 14:27):

afonso360 opened issue #5452:

:wave: Hey,

Fuzzgen found this when adding support for this instruction. This is very similar to #5199 but with select_spectre_guard instead of select.

.clif Test Case

test interpret
test run
set enable_llvm_abi_extensions=true
target x86_64

function %a(i128, i128, i128) -> i128 {
block0(v0: i128, v1: i128, v2: i128):
    v3 = select_spectre_guard.i128 v0, v1, v2
    return v3
}
; run: %a(1, 2, 3) == 2

Steps to Reproduce

Expected Results

The above tests to pass.

Actual Results

    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `/home/afonso/git/wasmtime/target/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`', cranelift/codegen/src/machinst/lower.rs:753:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`
FAIL ./lmao.clif: panicked in worker #0: should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main
Operating system: Linux
Architecture: x86_64

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 14:27):

afonso360 labeled issue #5452:

:wave: Hey,

Fuzzgen found this when adding support for this instruction. This is very similar to #5199 but with select_spectre_guard instead of select.

.clif Test Case

test interpret
test run
set enable_llvm_abi_extensions=true
target x86_64

function %a(i128, i128, i128) -> i128 {
block0(v0: i128, v1: i128, v2: i128):
    v3 = select_spectre_guard.i128 v0, v1, v2
    return v3
}
; run: %a(1, 2, 3) == 2

Steps to Reproduce

Expected Results

The above tests to pass.

Actual Results

    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `/home/afonso/git/wasmtime/target/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`', cranelift/codegen/src/machinst/lower.rs:753:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`
FAIL ./lmao.clif: panicked in worker #0: should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main
Operating system: Linux
Architecture: x86_64

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 14:27):

afonso360 labeled issue #5452:

:wave: Hey,

Fuzzgen found this when adding support for this instruction. This is very similar to #5199 but with select_spectre_guard instead of select.

.clif Test Case

test interpret
test run
set enable_llvm_abi_extensions=true
target x86_64

function %a(i128, i128, i128) -> i128 {
block0(v0: i128, v1: i128, v2: i128):
    v3 = select_spectre_guard.i128 v0, v1, v2
    return v3
}
; run: %a(1, 2, 3) == 2

Steps to Reproduce

Expected Results

The above tests to pass.

Actual Results

    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `/home/afonso/git/wasmtime/target/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`', cranelift/codegen/src/machinst/lower.rs:753:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`
FAIL ./lmao.clif: panicked in worker #0: should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main
Operating system: Linux
Architecture: x86_64

view this post on Zulip Wasmtime GitHub notifications bot (Dec 16 2022 at 22:18):

cfallin closed issue #5452:

:wave: Hey,

Fuzzgen found this when adding support for this instruction. This is very similar to #5199 but with select_spectre_guard instead of select.

.clif Test Case

test interpret
test run
set enable_llvm_abi_extensions=true
target x86_64

function %a(i128, i128, i128) -> i128 {
block0(v0: i128, v1: i128, v2: i128):
    v3 = select_spectre_guard.i128 v0, v1, v2
    return v3
}
; run: %a(1, 2, 3) == 2

Steps to Reproduce

Expected Results

The above tests to pass.

Actual Results

    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `/home/afonso/git/wasmtime/target/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`', cranelift/codegen/src/machinst/lower.rs:753:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`
FAIL ./lmao.clif: panicked in worker #0: should be implemented in ISLE: inst = `v3 = select_spectre_guard.i128 v0, v1, v2`, type = `Some(types::I128)`
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main
Operating system: Linux
Architecture: x86_64

Last updated: Nov 22 2024 at 16:03 UTC