Stream: git-wasmtime

Topic: wasmtime / issue #5435 cranelift-isle: codegen from new IR


view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 03:04):

github-actions[bot] commented on issue #5435:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 06:24):

jameysharp commented on issue #5435:

The "Doc build" and "Fuzz Targets" CI failures look to be due to using an older nightly Rust version (nightly-2022-09-07) than the stable release we're using for everything else. I used the new let-else syntax in this PR, which stabilized last month in Rust 1.65. I could remove that syntax from this PR without much disappointment.

The ubuntu-latest test failures tell me I forgot to run the ISLE tests, again. Most of those failures are due to integer constants that don't fit in their specified types, like what we discussed in #5423. There are also a couple hitting some asserts that I added at the last minute, so the asserts may be wrong.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 21:59):

jameysharp commented on issue #5435:

I've split the "easy" parts of this into separate commits in #5441 in hopes that we can get review of those parts out of the way quickly.


Last updated: Dec 23 2024 at 12:05 UTC