cfallin commented on issue #5429:
+1 for that further simplification if you're up for it, @uweigand (I'll turn off auto-merge here; happy to merge as-is as well if you'd prefer to follow up later)
uweigand commented on issue #5429:
+1 for that further simplification if you're up for it, @uweigand (I'll turn off auto-merge here; happy to merge as-is as well if you'd prefer to follow up later)
I'd prefer this to be merged as-is, followed by a patch changing the lower_branch result to
Unit
as discussed here https://github.com/bytecodealliance/wasmtime/pull/5427#discussion_r1047719631, followed by a patch to move all the asserts out of both lower and lower_branch up into common code.
jameysharp commented on issue #5429:
Okay, merged as-is! You can also open issues describing the next steps you'd like to see; these sound like good candidates for the "good first issue" label.
Last updated: Dec 23 2024 at 12:05 UTC