Stream: git-wasmtime

Topic: wasmtime / issue #5429 Simplify "unimplemented" operation...

Wasmtime GitHub notifications bot (Dec 13 2022 at 22:26):

cfallin commented on issue #5429:

+1 for that further simplification if you're up for it, @uweigand (I'll turn off auto-merge here; happy to merge as-is as well if you'd prefer to follow up later)

Wasmtime GitHub notifications bot (Dec 13 2022 at 22:31):

uweigand commented on issue #5429:

+1 for that further simplification if you're up for it, @uweigand (I'll turn off auto-merge here; happy to merge as-is as well if you'd prefer to follow up later)

I'd prefer this to be merged as-is, followed by a patch changing the lower_branch result to Unit as discussed here https://github.com/bytecodealliance/wasmtime/pull/5427#discussion_r1047719631, followed by a patch to move all the asserts out of both lower and lower_branch up into common code.

Wasmtime GitHub notifications bot (Dec 13 2022 at 23:24):

jameysharp commented on issue #5429:

Okay, merged as-is! You can also open issues describing the next steps you'd like to see; these sound like good candidates for the "good first issue" label.

Last updated: Nov 22 2024 at 17:03 UTC