Stream: git-wasmtime

Topic: wasmtime / issue #5427 Remove MachInst::gen_constant


view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 19:44):

github-actions[bot] commented on issue #5427:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 20:06):

abrown commented on issue #5427:

/bench_x64

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 21:02):

fitzgen commented on issue #5427:

Very nice clean up!!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2022 at 03:17):

jlb6740 commented on issue #5427:

@abrown .. It looks like your performance attempt /bench_x64 didn't run properly because the patch was already merged by the time the runner was picked up (even though you initiated the test before the run). A step in this action is to fetch all of the pull requests and check that request out after matching with the request id in the GITHUB_CONTEXT. In this case it was looking for 5427 but the pull request for 5427 did not exist. Look at the time stamps .. it looks like your job was picked up at "2022-12-13T20:06:14Z" while the patch was merged at about that time. I don't see the exact timestamp but it looks like your request came in ~hour later the patch was merged. The action was picked up about ~1 after your requested.


Last updated: Nov 22 2024 at 16:03 UTC