Stream: git-wasmtime

Topic: wasmtime / issue #5420 Cranelift: implement general selec...


view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2022 at 20:40):

cfallin commented on issue #5420:

Yes, exactly, I took the fallback rules for select and duplicated them for x86-64, aarch64, and riscv64 (s390x already supported the general case).

perhaps we should adopt the principle/goal that all combinations of CLIF which pass the validator should be implemented in any tier 1 backend? Whenever we fail that, it means we need to either change the instruction set, change the validator, or change the backend.

That sounds like a reasonable principle to me!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 00:39):

cfallin commented on issue #5420:

@fitzgen or @elliottt, would either of you be willing to review this?

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 00:46):

fitzgen commented on issue #5420:

Ah I thought that Jamey already reviewed it so I didn't leave a comment. Unclear to me whether Jamey wants changes on this PR after their review or not?

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2022 at 00:48):

cfallin commented on issue #5420:

I interpreted @jameysharp 's reply as: no changes needed, approach is fine, but:

That makes sense to me, at least for now. But I don't feel comfortable reviewing the actual implementations.

FWIW, the implementations are identical to the existing select cases in each backend, so hopefully these aren't too hard to review!


Last updated: Dec 23 2024 at 12:05 UTC