Wasmtime GitHub notifications bot (Dec 09 2022 at 01:10): Wasmtime GitHub notifications bot (Dec 09 2022 at 01:10):jameysharp commented on issue #5402:
The
sig_data_sizetest is failing now because you successfully made the struct 8 bytes smaller. Hooray! You should now assert that the size is 24 bytes.The other CI failures look like they might be temporary network errors, not an issue with your changes. Maybe by the time you push a fix for the
sig_data_sizetest, the other tests will pass again. If not, we'll have to look more closely at what's going wrong.
Wasmtime GitHub notifications bot (Dec 09 2022 at 18:53):jameysharp commented on issue #5402:
Apparently the other CI failures are a more general issue (#5407), so we won't be able to merge this until that's fixed, but we're working on it.
Wasmtime GitHub notifications bot (Dec 11 2022 at 02:32):tnachen commented on issue #5402:
@jameysharp looks like CI is passed now! I don't know if we should change compute_arg_locs or not, it's fairly isolated so I totally can.
Wasmtime GitHub notifications bot (Dec 11 2022 at 12:45):tnachen commented on issue #5402:
Just made the compute_arg_loc changes, PTAL
Last updated: Nov 22 2024 at 16:03 UTC