github-actions[bot] commented on issue #5383:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
jameysharp commented on issue #5383:
Oh. When I first wrote the
bindings_for
function it was in another module and I didn't want to make theTupleIndex
internals public, so I wrote theIntoIterator
implementation as a more limited thing, and found it was useful in several places. Then I movedbindings_for
here and started using it everywhere but didn't notice that it became the only user of that iterator.This is one reason why we do code review, I guess!
Last updated: Dec 23 2024 at 12:05 UTC