Stream: git-wasmtime

Topic: wasmtime / issue #5383 cranelift-isle: Factor constraint/...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2022 at 17:14):

github-actions[bot] commented on issue #5383:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2022 at 01:45):

jameysharp commented on issue #5383:

Oh. When I first wrote the bindings_for function it was in another module and I didn't want to make the TupleIndex internals public, so I wrote the IntoIterator implementation as a more limited thing, and found it was useful in several places. Then I moved bindings_for here and started using it everywhere but didn't notice that it became the only user of that iterator.

This is one reason why we do code review, I guess!

Last updated: Nov 22 2024 at 16:03 UTC