Stream: git-wasmtime

Topic: wasmtime / issue #5360 Should dominator tree be borrowed ...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2022 at 10:31):

antonromanov1 opened issue #5360:

https://github.com/bytecodealliance/wasmtime/blob/37c3c5b1e0ca0c9cece48881d71647c1189979f6/cranelift/codegen/src/dce.rs#L14
Each call inside (is_valid, cfg_postorder) is immutable.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2022 at 10:31):

antonromanov1 commented on issue #5360:

@cfallin please take a look.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2022 at 22:44):

cfallin commented on issue #5360:

Yep, it looks like we could modify the function to take an immutable borrow instead. Happy to review a PR if you want to make one.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2022 at 02:10):

jameysharp commented on issue #5360:

Looks like you fixed this in #5371 and that's been merged, so I'm closing this issue. Thank you!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2022 at 02:10):

jameysharp closed issue #5360:

https://github.com/bytecodealliance/wasmtime/blob/37c3c5b1e0ca0c9cece48881d71647c1189979f6/cranelift/codegen/src/dce.rs#L14
Each call inside (is_valid, cfg_postorder) is immutable.

Last updated: Nov 22 2024 at 16:03 UTC