jameysharp commented on issue #5318:
Now I've tested this with new unreachable-rule checks I'm working on, and it works great, even for errors which need to cite rules from multiple files, both with and without pretty error formatting:
more general higher-priority rule shadows other rules src/isa/aarch64/lower.isle:1936:6: (rule (lower (has_type ty (swiden_low x))) src/isa/aarch64/lower_dynamic_neon.isle:104:6: (rule -1 (lower (has_type ty (swiden_low x)))
error: more general higher-priority rule shadows other rules ┌─ src/isa/aarch64/lower.isle:1936:7 │ 1936 │ (rule (lower (has_type ty (swiden_low x))) │ ^ │ ┌─ src/isa/aarch64/lower_dynamic_neon.isle:104:7 │ 104 │ (rule -1 (lower (has_type ty (swiden_low x))) │ -
Future work: track
Span
instead ofPos
during lexing and parsing, so this kind of error reporting can correctly show the whole rule.
github-actions[bot] commented on issue #5318:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Last updated: Dec 23 2024 at 12:05 UTC