Stream: git-wasmtime

Topic: wasmtime / issue #5318 cranelift-isle: Rewrite error repo...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2022 at 00:55):

jameysharp commented on issue #5318:

Now I've tested this with new unreachable-rule checks I'm working on, and it works great, even for errors which need to cite rules from multiple files, both with and without pretty error formatting:

  more general higher-priority rule shadows other rules
  src/isa/aarch64/lower.isle:1936:6: (rule (lower (has_type ty (swiden_low x)))
  src/isa/aarch64/lower_dynamic_neon.isle:104:6: (rule -1 (lower (has_type ty (swiden_low x)))

  error: more general higher-priority rule shadows other rules
       ┌─ src/isa/aarch64/lower.isle:1936:7
       │
  1936 │ (rule (lower (has_type ty (swiden_low x)))
       │       ^
       │
       ┌─ src/isa/aarch64/lower_dynamic_neon.isle:104:7
       │
   104 │ (rule -1 (lower (has_type ty (swiden_low x)))
       │       -

Future work: track Span instead of Pos during lexing and parsing, so this kind of error reporting can correctly show the whole rule.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2022 at 01:59):

github-actions[bot] commented on issue #5318:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Nov 22 2024 at 17:03 UTC