Wasmtime GitHub notifications bot (Nov 17 2022 at 00:30): Wasmtime GitHub notifications bot (Nov 17 2022 at 00:30):jameysharp commented on issue #5287:
I thought building the C API involves building all of Wasmtime. So I would expect most of the build time to be shared between the two sets of tests.
Wasmtime GitHub notifications bot (Nov 17 2022 at 00:33):elliottt commented on issue #5287:
I thought building the C API involves building all of Wasmtime. So I would expect most of the build time to be shared between the two sets of tests.
Looking through the build log, it appears to rebuild all dependencies for each of the two steps. The explanation that Alex and I came up with was that the build flags are different enough that the artifacts aren't reused between the two.
Wasmtime GitHub notifications bot (Nov 17 2022 at 17:30):elliottt commented on issue #5287:
Unfortunately I'm not seeing significant benefit from this PR. Originally it seemed like there was enough rebuilt between the cmake and cargo test parts of the
Testjob that this would help build times, but after a few runs it appears that there was more work shared between those two than we thought.
Last updated: Nov 22 2024 at 16:03 UTC