Stream: git-wasmtime

Topic: wasmtime / issue #5286 Skip running release builds on PRs

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:25):

elliottt commented on issue #5286:

This looks reasonable to me, thanks! Could the if condition be changed though to still run builds for PRs to release-* branches? Those are much rarer but a bit more critical to make sure we get everything right so I think it'd be good to keep it running there.

Great point, I'll add that in!

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:35):

jameysharp commented on issue #5286:

I guess doing as Alex suggests with the release-* branches also answers the question about whether to keep the existing if condition: We should keep it because the job will run in cases where we don't want to publish any build artifacts.

Wasmtime GitHub notifications bot (Nov 17 2022 at 17:31):

elliottt commented on issue #5286:

I'm going to change the branch build rule temporarily to check that the pull_request changes make sense, but will revert that before merging.

Last updated: Oct 23 2024 at 20:03 UTC