Stream: git-wasmtime

Topic: wasmtime / issue #5268 wiggle: Refactor with fewer raw po...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 15 2022 at 02:55):

github-actions[bot] commented on issue #5268:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Nov 15 2022 at 17:09):

alexcrichton commented on issue #5268:

Ah yes indeed sorry about that. The wiggle-generated implementations of GuestTypeTransparent were all unsafe in the face of shared memories since they do raw pointer reads/writes and needed treatment somehow. One option would be to switch to atomic loads as was done for primitive integers, but I opted instead to change the definition of GuestTypeTransparent to require "all bits valid" and then I went ahead and removed the auto-generated implementations. I don't think anything needs GuestTypeTransparent, or at least not in WASI today, and it otherwise represents the ambitions-at-the-time which have since been eclipsed by the component model.

Last updated: Nov 22 2024 at 17:03 UTC