Stream: git-wasmtime

Topic: wasmtime / issue #5226 Wasmtime+Cranelift: strip out some...

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:20):

bjorn3 commented on issue #5226:

This broke doing a check build of cg_clif on x86, which rust's CI does. I use cranelift-native for implementing -Ctarget-cpu=native in cg_clif. For this purpose just returning no features on unsupported platforms is fine.

https://github.com/rust-lang/rust/actions/runs/3999165664/jobs/6862725564#step:26:1343

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:24):

cfallin commented on issue #5226:

@bjorn3 IMHO it's reasonable for cranelift-native to refuse to compile on a platform (i686) that Cranelift doesn't support, since its purpose is to query what the native platform is from Cranelift's point of view. Is there a way to exclude the cg_clif check build from running there?

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:26):

bjorn3 commented on issue #5226:

Is there a way to exclude the cg_clif check build from running there?

Probably, but it would also break cross-compiling scenarios where cranelift-native would never be called at runtime.

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:31):

cfallin commented on issue #5226:

Hmm, yeah, actually it seems that any other non-supported platform will compile here (returning an Err at runtime); that's probably the more reasonable option. Happy to review a PR to remove the block with the compile-error. The original issue we were trying to solve was that folks were trying to build Cranelift embedders (like Wasmtime or Viceroy wrapping it) for i686 and were misled by a successful compile; but I suppose a runtime error is still good enough for that purpose since it's clear enough ("unsupported architecture").

Wasmtime GitHub notifications bot (Jan 24 2023 at 18:38):

bjorn3 commented on issue #5226:

Opened https://github.com/bytecodealliance/wasmtime/pull/5627

Last updated: Nov 22 2024 at 16:03 UTC