Wasmtime GitHub notifications bot (Nov 05 2022 at 12:51): Wasmtime GitHub notifications bot (Nov 05 2022 at 12:51):ShuP1 commented on issue #5210:
Are the pipes safe to span threads?
Safe to move to another thread but may lock.Or even maybe dead lock during concurrent use ?
This reaches the limit of my understand of rust async...https://docs.rs/wasi-common/latest/src/wasi_common/pipe.rs.html#112
RwLockis locked in an async function who does not use await.
So no "context switch" ? and no risk for another thread to hung on this lock ?
Wasmtime GitHub notifications bot (Nov 05 2022 at 12:52):ShuP1 commented on issue #5210:
I'd avoid wasm_byte_vec_t as it's cumbersome to work with and instead use read/write-style buffer passing
Does this point also includes changing that ?
void wasi_config_set_stdin_bytes(wasi_config_t* config, wasm_byte_vec_t* binary); // to void wasi_config_set_stdin_bytes(wasi_config_t* config, const byte_t*, size_t);
Wasmtime GitHub notifications bot (Nov 05 2022 at 13:00):github-actions[bot] commented on issue #5210:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:c-api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Last updated: Nov 22 2024 at 17:03 UTC