Stream: git-wasmtime

Topic: wasmtime / issue #5204 Fix mprotect failures by enabling ...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 04 2022 at 18:20):

bjorn3 commented on issue #5204:

See https://github.com/bytecodealliance/wasmtime/issues/4986

view this post on Zulip Wasmtime GitHub notifications bot (Nov 04 2022 at 18:35):

uweigand commented on issue #5204:

Updated cfg checks to prevent breaking windows builds with selinux-fix.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 04 2022 at 20:01):

uweigand commented on issue #5204:

This PR is equivalent to fixing #4986 by turning the selinux-fix feature on for everybody.

The intent of the PR is to turn on selinux-fix for the filetests crate only, which should not be performance-critical. It's limited to filetests because only there I'm seeing an actual immediate issue (failing tests) right now.

I agree that we should move to mmap everywhere, but that is performance-critical, and there may be better ways than the selinux-fix (I haven't looked into the implementation in detail, and I'm sure others are more familiar with that ...)

Last updated: Dec 23 2024 at 12:05 UTC