Stream: git-wasmtime

Topic: wasmtime / issue #5195 cranelift-isle: New IR and revised...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 04 2022 at 01:42):

github-actions[bot] commented on issue #5195:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Nov 04 2022 at 21:39):

jameysharp commented on issue #5195:

Printing errors with Miette is crashing for me, and quoting way too much of the source code when it doesn't crash, and I don't understand why.

But I'm disabling the new "rule shadowed by more general higher-priority rule" errors anyway because I want to merge this before fixing them in the backends. Anyway, builds don't normally turn on Miette, so I'm hoping to merge this without getting Miette exactly right.

Otherwise I think this is ready to merge so I'd appreciate review.

By the way, the number of rules which currently can't fire due to higher-priority rules always matching first is:

Apparently there aren't any rules in any backends which attempt to constrain a binding site in two incompatible ways, like (and 1 2), so that's reassuring.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 07 2022 at 16:15):

jameysharp commented on issue #5195:

I have a plausible hypothesis about why I was having trouble with Miette. The Error::Errors case, which contains a Vec<Error>, is handled in error_miette.rs by returning all the errors from miette::Diagnostic::related. I think Miette is then trying to report the source code for a span containing all of those errors at once. I think the panic I saw was when different errors came from different source files, so it couldn't cover them all in one span.

Rather than fix any of that right now, I've just removed all my attempts to use Miette "properly" in this PR. Instead, the new errors are reported with basically the same simple text formatting whether Miette is enabled or not.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2022 at 20:22):

jameysharp commented on issue #5195:

As a data point, this PR has passed about 11 million executions of ISLE's fuzzer (when combined with #5236).

Last updated: Dec 23 2024 at 12:05 UTC