Stream: git-wasmtime

Topic: wasmtime / issue #5149 Return `anyhow::Error` from host f...

Wasmtime GitHub notifications bot (Oct 28 2022 at 16:34):

github-actions[bot] commented on issue #5149:

Subscribe to Label Action

cc @fitzgen, @kubkon, @peterhuene

<details>
This issue or pull request has been labeled: "fuzzing", "wasi", "wasmtime:api", "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing
• kubkon: wasi
• peterhuene: wasmtime:api, wasmtime:c-api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Nov 01 2022 at 17:58):

alexcrichton commented on issue #5149:

Ok I'm actually working through a good deal more refactorings for Trap, namely I've done away with all the internal structure of Trap in favor of just enum Trap { ... } where backtrace information is always attached via a .context(...) call. This fixes a prior issue with this PR that accidentally brought back the O(n^2) behavior if a non-Trap was returned.

I still have some more documentation I'd like to update, however, and additionally rename BacktraceContext to WasmBacktrace and shuffle around its struct definition. This has what should be the main meat of what @pchickey and I have settled on.

Wasmtime GitHub notifications bot (Nov 01 2022 at 19:18):

alexcrichton commented on issue #5149:

@pchickey mind double-checking the most recent few commits to confirm they look ok to you?

Wasmtime GitHub notifications bot (Nov 01 2022 at 19:30):

github-actions[bot] commented on issue #5149:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Last updated: Nov 22 2024 at 17:03 UTC