Stream: git-wasmtime

Topic: wasmtime / issue #5127 Cranelift: Use a single, shared ve...

Wasmtime GitHub notifications bot (Oct 31 2022 at 20:13):

fitzgen commented on issue #5127:

After a hurried skim: I think a bunch of these changes would be more clear if e.g. SigData::args moved to SigSet, so you could say ctx.sigs().args(self.sig) instead of ctx.sigs()[self.sig].args(ctx.sigs()).

I started experimenting with this and it was a pretty invasive change because a bunch of existing SigData methods use self.args(..) and self.rets(..) but don't have access to their own Sig, so basically all methods of SigData would have to move to SigSet and this just seems like too much ocean boiling for not enough benefit.

Last updated: Nov 22 2024 at 17:03 UTC