Stream: git-wasmtime

Topic: wasmtime / issue #5078 Perform I-Cache Maintenance on RIS...

Wasmtime GitHub notifications bot (Oct 27 2022 at 06:01):

yuyang-ok commented on issue #5078:

@afonso360 @bjorn3 I think we are ready.

Wasmtime GitHub notifications bot (Nov 01 2022 at 05:14):

yuyang-ok commented on issue #5078:

@bjorn3 @afonso360 I think we are ready.

Wasmtime GitHub notifications bot (Nov 01 2022 at 14:18):

afonso360 commented on issue #5078:

This looks correct to me.

Wasmtime GitHub notifications bot (Nov 02 2022 at 02:23):

yuyang-ok commented on issue #5078:

I think I am in favour of store num_cpu in static. @cfallin @bjorn3 @afonso360

Wasmtime GitHub notifications bot (Nov 02 2022 at 02:36):

yuyang-ok edited a comment on issue #5078:

I think I am in favour of store num_cpu in static. @cfallin @bjorn3 @afonso360
feature is hard to used.

Wasmtime GitHub notifications bot (Nov 02 2022 at 02:38):

yuyang-ok edited a comment on issue #5078:

I think I am in favour of store num_cpu in static. @cfallin @bjorn3 @afonso360
feature is hard to use.

Wasmtime GitHub notifications bot (Nov 02 2022 at 06:50):

yuyang-ok commented on issue #5078:

I am having this error.

yuyang@yuyang-Inspiron-7590:~/projects/wasmtime/crates/jit-icache-coherence$ cargo t --target riscv64gc-unknown-linux-gnu
Compiling wasmtime-jit-icache-coherence v2.0.0 (/home/yuyang/projects/wasmtime/crates/jit-icache-coherence)
error[E0015]: cannot call non-const fn num_cpus::get in statics
--> crates/jit-icache-coherence/src/libc.rs:12:35
|
12 | static NUM_CPUS: usize = unsafe { num_cpus::get() };
| ^^^^^^^^^^^^^^^
|
= note: calls in statics are limited to constant functions, tuple structs and tuple variants

For more information about this error, try rustc --explain E0015.
error: could not compile wasmtime-jit-icache-coherence due to previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile wasmtime-jit-icache-coherence due to previous error

In rust I have to use `lazy_static` to assign  this value??

Wasmtime GitHub notifications bot (Nov 02 2022 at 08:11):

yuyang-ok deleted a comment on issue #5078:

I am having this error.

yuyang@yuyang-Inspiron-7590:~/projects/wasmtime/crates/jit-icache-coherence$ cargo t --target riscv64gc-unknown-linux-gnu
Compiling wasmtime-jit-icache-coherence v2.0.0 (/home/yuyang/projects/wasmtime/crates/jit-icache-coherence)
error[E0015]: cannot call non-const fn num_cpus::get in statics
--> crates/jit-icache-coherence/src/libc.rs:12:35
|
12 | static NUM_CPUS: usize = unsafe { num_cpus::get() };
| ^^^^^^^^^^^^^^^
|
= note: calls in statics are limited to constant functions, tuple structs and tuple variants

For more information about this error, try rustc --explain E0015.
error: could not compile wasmtime-jit-icache-coherence due to previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile wasmtime-jit-icache-coherence due to previous error

In rust I have to use `lazy_static` to assign  this value??

Wasmtime GitHub notifications bot (Nov 17 2022 at 01:45):

yuyang-ok commented on issue #5078:

@bjorn3 @afonso360 @alexcrichton @cfallin I think we are ready.

Wasmtime GitHub notifications bot (Feb 01 2023 at 04:38):

yuyang-ok commented on issue #5078:

@cfallin Are we going to merge this or not?

Wasmtime GitHub notifications bot (Feb 01 2023 at 09:03):

yuyang-ok commented on issue #5078:

@cfallin Yeah,I can rebase.:-)

Wasmtime GitHub notifications bot (Feb 02 2023 at 16:23):

cfallin commented on issue #5078:

@yuyang-ok unfortunately this seems to be failing a number of tests now -- bad merge?

Last updated: Nov 22 2024 at 17:03 UTC