Stream: git-wasmtime

Topic: wasmtime / issue #5057 Bench-api --engine-flags can't acc...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 15 2022 at 00:18):

brianjjones opened issue #5057:

Thanks for filing a bug report! Please fill out the TODOs below.

Note: if you want to report a security issue, please read our security policy!

Test Case

TODO: upload Wasm file here

Steps to Reproduce

1.) Build bench-api.
2.) sightglass-cli benchmark ... --engine-flags '--wasi-modules experimental-wasi-nn'

Expected Results

Benchmark runs to completion

Actual Results

error: Found argument '--wasi-modules experimental-wasi-nn' which wasn't expected, or isn't valid in this context

Versions and Environment

wasmtime commit ff0c45b4a069a84b131c8265d8d14c2f7d0566d7

Operating system: ubuntu 20.04

Architecture: x86

Extra Info

--engine-flags appears to not be able to accept a string that starts with --, so you are unable to set the flag needed to cause wasi-nn to be linked at runtime. This means wasi-nn can't be used by Sightglass currently.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 15 2022 at 00:18):

brianjjones labeled issue #5057:

Thanks for filing a bug report! Please fill out the TODOs below.

Note: if you want to report a security issue, please read our security policy!

Test Case

TODO: upload Wasm file here

Steps to Reproduce

1.) Build bench-api.
2.) sightglass-cli benchmark ... --engine-flags '--wasi-modules experimental-wasi-nn'

Expected Results

Benchmark runs to completion

Actual Results

error: Found argument '--wasi-modules experimental-wasi-nn' which wasn't expected, or isn't valid in this context

Versions and Environment

wasmtime commit ff0c45b4a069a84b131c8265d8d14c2f7d0566d7

Operating system: ubuntu 20.04

Architecture: x86

Extra Info

--engine-flags appears to not be able to accept a string that starts with --, so you are unable to set the flag needed to cause wasi-nn to be linked at runtime. This means wasi-nn can't be used by Sightglass currently.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 15 2022 at 00:20):

brianjjones commented on issue #5057:

@abrown This is the issue we discussed today.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 15 2022 at 01:25):

fitzgen commented on issue #5057:

It works if you do --engine-flags="--foo" with the = in there. This makes sense to me since the CLI parser otherwise can't determine whether this should be parsed as ["--engine-flags", "--foo"] or ["--engine-flags=--foo"].

view this post on Zulip Wasmtime GitHub notifications bot (Oct 17 2022 at 18:45):

brianjjones commented on issue #5057:

Ah good to know thanks. It still fails to set wasi-modules.wasi-nn when I use --engine-flags="--wasi-modules=experimental-wasi-nn" . Which results in target/debug/sightglass-cli benchmark benchmarks/wasi-nn/benchmark.wasm --engine engines/wasmtime/libengine.so --engine-flags=-wasi-modules=experimental-wasi-nn

Any ideas on what else could be going wrong?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 17 2022 at 18:46):

brianjjones edited a comment on issue #5057:

Ah good to know thanks. It still fails to set wasi-modules.wasi-nn when I use --engine-flags="--wasi-modules=experimental-wasi-nn" . Which results in target/debug/sightglass-cli benchmark benchmarks/wasi-nn/benchmark.wasm --engine engines/wasmtime/libengine.so --engine-flags=--wasi-modules=experimental-wasi-nn

Any ideas on what else could be going wrong?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 17 2022 at 19:14):

brianjjones edited a comment on issue #5057:

Ah good to know thanks. It still fails to set wasi-modules.wasi-nn when I use --engine-flags="--wasi-modules=experimental-wasi-nn" . Which results in target/debug/sightglass-cli benchmark benchmarks/wasi-nn/benchmark.wasm --engine engines/wasmtime/libengine.so --engine-flags=--wasi-modules=experimental-wasi-nn

Any ideas on what else could be going wrong?

Edit: It appears BenchState::new is being passed None for options. I'm looking into it to see if I can offer a fix.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2022 at 00:37):

brianjjones commented on issue #5057:

This appears to be a Sightglass issue, so most likely not a Wasmtime bug.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 18 2022 at 00:37):

brianjjones closed issue #5057:

Thanks for filing a bug report! Please fill out the TODOs below.

Note: if you want to report a security issue, please read our security policy!

Test Case

TODO: upload Wasm file here

Steps to Reproduce

1.) Build bench-api.
2.) sightglass-cli benchmark ... --engine-flags '--wasi-modules experimental-wasi-nn'

Expected Results

Benchmark runs to completion

Actual Results

error: Found argument '--wasi-modules experimental-wasi-nn' which wasn't expected, or isn't valid in this context

Versions and Environment

wasmtime commit ff0c45b4a069a84b131c8265d8d14c2f7d0566d7

Operating system: ubuntu 20.04

Architecture: x86

Extra Info

--engine-flags appears to not be able to accept a string that starts with --, so you are unable to set the flag needed to cause wasi-nn to be linked at runtime. This means wasi-nn can't be used by Sightglass currently.

Last updated: Nov 22 2024 at 16:03 UTC