Stream: git-wasmtime

Topic: wasmtime / issue #5043 Cranelift: Derive `Copy` for `Inst...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2022 at 14:54):

jameysharp commented on issue #5043:

Oh, one more thought: maybe hold off merging this until Chris gets to merge the egraph PR, because I'm pretty sure it'll have mild conflicts and I don't want him to have to rebase again. :sweat_smile:

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2022 at 20:04):

fitzgen commented on issue #5043:

@cfallin should I hold off on landing this until after the e-graphs PR?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2022 at 20:05):

fitzgen commented on issue #5043:

Maybe also add a test that InstructionData is 16 bytes (like the comment above it claims)?

Done.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2022 at 20:20):

cfallin commented on issue #5043:

@cfallin should I hold off on landing this until after the e-graphs PR?

Yes please, if you don't mind! It will hopefully merge today (if review finishes out well) and while this is a small PR, it will conflict with my code motion I think and I've rebased a bunch of times already...

Last updated: Nov 22 2024 at 16:03 UTC