Stream: git-wasmtime

Topic: wasmtime / issue #5039 lift for bool: out of bounds when ...

Wasmtime GitHub notifications bot (Oct 11 2022 at 06:16):

github-actions[bot] commented on issue #5039:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Oct 11 2022 at 14:58):

alexcrichton commented on issue #5039:

Ah this is actually an intentional change made to the component model historically where out-of-bounds booleans/integers are silently "truncated" now instead of having a trap like they did before, so I think we're going to need to update the invalid.rs test to probably pass both invalid and valid-but-not-code-generated things.

Wasmtime GitHub notifications bot (Oct 11 2022 at 14:59):

alexcrichton commented on issue #5039:

One thing worth mentioning as well perhaps is that instead of using wit-bindgen for the guest (e.g. wasm.rs) it would be relatively simple to make a wasm.wat where we write the raw text format for these low-level tests like the we do in this repository.

Last updated: Nov 22 2024 at 17:03 UTC