Stream: git-wasmtime

Topic: wasmtime / issue #5023 Fix StructReturn handling: properl...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2022 at 19:58):

cfallin commented on issue #5023:

Draft PR because this seems to be causing issues in another call filetest that I'm chasing down now...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2022 at 20:56):

bjorn3 commented on issue #5023:

I just successfully ran the entire cg_clif test suite. Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2022 at 18:35):

cfallin commented on issue #5023:

@elliottt I think this is ready for a proper review now -- thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2022 at 22:22):

cfallin commented on issue #5023:

I'll backport to the 2.0 release branch once this merges.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2022 at 23:31):

cfallin commented on issue #5023:

@abrown it looks like the wasi-nn CI job is hitting 404s when trying to install OpenVino. Could you take a look?

wasi-nn support is tier 3, so if is still an issue tomorrow sometime, I'll plan to disable the CI job to get this merged, since it is a miscompilation and needs to not be held back for too long.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2022 at 23:41):

cfallin commented on issue #5023:

wasi-nn support is tier 3, so if is still an issue tomorrow sometime, I'll plan to disable the CI job to get this merged, since it is a miscompilation and needs to not be held back for too long.

Actually I restarted the job a few times and it looks like a consistent failure from a broken upstream package repository, so I created #5028 to let this be fixed off the critical path...


Last updated: Dec 23 2024 at 12:05 UTC