Stream: git-wasmtime

Topic: wasmtime / issue #5020 fuzzgen: Generate compiler flags

Wasmtime GitHub notifications bot (Oct 05 2022 at 14:39):

github-actions[bot] commented on issue #5020:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "fuzzing"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Oct 10 2022 at 19:19):

afonso360 commented on issue #5020:

This PR had some performance issues:

• The regalloc checker started consuming a bunch of time (around 45%) so we now try to minimize runs with it (10% with the current iteration).

• I've also had to limit the amount of runs that we allow, at some point the fuzzer decided that spending 100% of the time in the interpreter was a good idea, and started generating huge inputs, that were in the order of 20k runs each. (up to 130k!)

execs/s seems way better than before, which is nice.

And for those who are interested, here's a flamegraph of where we spend time. This is about 1min at 1Khz around 190k inputs into my normal benchmark run:


Wasmtime GitHub notifications bot (Oct 10 2022 at 19:20):

afonso360 edited a comment on issue #5020:

This PR had some performance issues:

• The regalloc checker started consuming a bunch of time (around 45%) so we now try to minimize runs with it (10% with the current iteration).

• I've also had to limit the amount of runs that we allow, at some point the fuzzer decided that spending 100% of the time in the interpreter was a good idea, and started generating huge inputs, that were in the order of 20k runs each. (up to 130k!)

execs/s seems way better than before, which is nice.

And for those who are interested, here's a flamegraph of where we spend time. This is about 2min at 1Khz around 190k inputs into my normal benchmark run:


Wasmtime GitHub notifications bot (Oct 10 2022 at 19:22):

afonso360 edited a comment on issue #5020:

This PR had some performance issues:

• The regalloc checker started consuming a bunch of time (around 45%) so we now try to minimize runs with it (10% with the current iteration).

• I've also had to limit the amount of runs that we allow, at some point the fuzzer decided that spending 100% of the time in the interpreter was a good idea, and started generating huge inputs, that were in the order of 20k runs each. (up to 130k!)

execs/s seems way better than before, which is nice.

And for those who are interested, here's a flamegraph of where we spend time. This is about 2min at 1Khz around 190k inputs into my normal benchmark run:


Edit: I should note, this is all on top of #5034

Wasmtime GitHub notifications bot (Oct 17 2022 at 21:17):

afonso360 commented on issue #5020:

I've given this one round of fuzzing on AArch64 and x86, and it found the two issues with iconst, one has already been fixed in #5061 and I'm working on removing iconst.i128, once that is merged I'll give this another round of fuzzing and if everything goes right we should be able to merge this.

Wasmtime GitHub notifications bot (Oct 20 2022 at 21:16):

afonso360 commented on issue #5020:

@cfallin What do you think about merging this with the use_egraphs flag commented out and enabling that on a separate PR?

It's getting a bit annoying having to rebase my other work on this PR just to fuzz it. I've fuzzed this for about an hour on both AArch64 and x86 without use_egraphs and it seems stable.

Wasmtime GitHub notifications bot (Oct 20 2022 at 21:22):

cfallin commented on issue #5020:

Oh, for sure, I didn't know we were waiting on something here; sorry! I was waiting for your go-ahead to merge. FWIW the PR is still marked as a draft; go ahead and transition it to "Ready for review" when you want me to merge.

I actually think maybe it's fine to include use_egraphs; better to get the fuzzbugs coming sooner than later, and I'm happy to take them as they come in. But I'm open to the other approach if you think otherwise.

Wasmtime GitHub notifications bot (Oct 20 2022 at 22:41):

afonso360 commented on issue #5020:

Oh, for sure, I didn't know we were waiting on something here; sorry!
I wasn't really, I just got a bit annoyed today at having to do a rebase for the third time, that's where that suggestion came from!

I'm okay with merging this as is and letting fuzzgen report issues as we go along.

Wasmtime GitHub notifications bot (Oct 20 2022 at 22:41):

afonso360 edited a comment on issue #5020:

Oh, for sure, I didn't know we were waiting on something here; sorry!

I wasn't really, I just got a bit annoyed today at having to do a rebase for the third time, that's where that suggestion came from!

I'm okay with merging this as is and letting ossfuzz report issues as we go along.

Last updated: Oct 23 2024 at 20:03 UTC