Stream: git-wasmtime

Topic: wasmtime / issue #5017 Tls and abi for riscv64.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2022 at 08:02):

yuyang-ok commented on issue #5017:

I think I have finish this, But not tested.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2022 at 10:44):

bjorn3 commented on issue #5017:

frontend_config is a method on the TargetIsa trait, which by default calls the default_call_conv method on the same trait to get the right call conv. Could you please implement default_call_conv of the TargetIsa trait instead?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2022 at 01:01):

github-actions[bot] commented on issue #5017:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2022 at 02:59):

yuyang-ok commented on issue #5017:

@bjorn3 system_v_riscv_float_abi has been tested, I think tls_value cann't have more meaningful test right now.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2022 at 06:39):

yuyang-ok edited a comment on issue #5017:

@bjorn3 system_v_riscv_float_abi has been tested, I think tls_value cann't have more meaningful test right now at current framework.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2022 at 02:50):

yuyang-ok commented on issue #5017:

Is there some run test against https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/filetests/filetests/isa/x64/tls_elf.clif
looks like not right.
you just load the addr, should load_i64 after load the addr.

movq %rax, [%rax]

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2022 at 03:25):

yuyang-ok commented on issue #5017:

I am little confused about the problem,How about merge and support riscv float abi.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2023 at 12:01):

bjorn3 commented on issue #5017:

https://github.com/bytecodealliance/wasmtime/pull/7003 has implemented TLS support for riscv64.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2023 at 13:55):

alexcrichton commented on issue #5017:

Indeed! I'll close this in that case and it can be resubmitted with a rebase if necessary still.

Last updated: Dec 23 2024 at 12:05 UTC