Stream: git-wasmtime

Topic: wasmtime / issue #4991 cranelift: update x64 inst_size_test

Wasmtime GitHub notifications bot (Oct 01 2022 at 11:46):

pepyakin commented on issue #4991:

Yep, it does.

Wasmtime GitHub notifications bot (Oct 01 2022 at 13:20):

cfallin commented on issue #4991:

Out of curiosity, were you seeing issues with a nightly compiler, or something else (local changes, etc)?

Wasmtime GitHub notifications bot (Oct 01 2022 at 13:34):

afonso360 commented on issue #4991:

I ran into this issue as well, I think I tried the nightly compiler and it started failing, reverting back to stable works. (This was a few days ago so I'm not totally sure on the details)

Wasmtime GitHub notifications bot (Oct 01 2022 at 14:12):

pepyakin commented on issue #4991:

Oh, yeah, I also thought it's nightly misbehaving, but running

rustup run --install stable cargo test -p cranelift-codegen -- isa::x64::inst::inst_size_test

resulted in the same panic! (rustc 1.64.0 (a55dd71d5 2022-09-19))

Wasmtime GitHub notifications bot (Oct 01 2022 at 14:23):

afonso360 commented on issue #4991:

That's weird, I tried updating my stable version, and I'm now on:

stable-x86_64-pc-windows-msvc (default)
rustc 1.64.0 (a55dd71d5 2022-09-19)

And running cargo +stable test -p cranelift-codegen -- isa::x64::inst::inst_size_test passes the test for me. :thinking:

Wasmtime GitHub notifications bot (Oct 01 2022 at 14:24):

afonso360 edited a comment on issue #4991:

That's weird, I tried updating my stable version, and I'm now on:

stable-x86_64-pc-windows-msvc (default)
rustc 1.64.0 (a55dd71d5 2022-09-19)

And running cargo +stable test -p cranelift-codegen -- isa::x64::inst::inst_size_test passes the test for me. :thinking:

Edit: cargo +nightly test -p cranelift-codegen -- isa::x64::inst::inst_size_test does fail the test.

Wasmtime GitHub notifications bot (Oct 01 2022 at 18:18):

lqd commented on issue #4991:

Could it be from the new enum layout from https://github.com/rust-lang/rust/pull/94075 ?

Wasmtime GitHub notifications bot (Nov 03 2022 at 16:54):

jameysharp commented on issue #4991:

We're merging an identical patch now in #5188. I'm glad you all brought this up early so it wasn't a surprise!

Last updated: Nov 22 2024 at 17:03 UTC