Stream: git-wasmtime

Topic: wasmtime / issue #4967 Allow WASI to open directories wit...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 27 2022 at 02:37):

github-actions[bot] commented on issue #4967:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Sep 27 2022 at 22:24):

sunfishcode commented on issue #4967:

Implementation LGTM.

Since you took the test from #4947, is there a reason you didn't just cherry-pick fe33e29 in this PR?

Just that I didn't notice it was a separate commit. I've now rebased this PR to cherry-pick that patch.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 22:37):

jameysharp commented on issue #4967:

Since bytecodealliance/cap-std#277 merged, can this issue be fixed without race conditions now?

What I would expect, coming from a POSIX perspective, is to call Dir::open on the given path (apparently with the maybe_dir open flag for Windows), then check f.metadata().is_dir(). If it was a directory, it looks to me like Dir::from_std_file(f.into_std()) would fix up the Rust types to reflect reality.

Is that a reasonable approach?

Last updated: Nov 22 2024 at 16:03 UTC