github-actions[bot] commented on issue #4967:
Subscribe to Label Action
cc @kubkon
<details>
This issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
- kubkon: wasi
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
sunfishcode commented on issue #4967:
Implementation LGTM.
Since you took the test from #4947, is there a reason you didn't just cherry-pick fe33e29 in this PR?
Just that I didn't notice it was a separate commit. I've now rebased this PR to cherry-pick that patch.
jameysharp commented on issue #4967:
Since bytecodealliance/cap-std#277 merged, can this issue be fixed without race conditions now?
What I would expect, coming from a POSIX perspective, is to call
Dir::open
on the given path (apparently with themaybe_dir
open flag for Windows), then checkf.metadata().is_dir()
. If it was a directory, it looks to me likeDir::from_std_file(f.into_std())
would fix up the Rust types to reflect reality.Is that a reasonable approach?
Last updated: Dec 23 2024 at 12:05 UTC